PengZheng commented on code in PR #727: URL: https://github.com/apache/celix/pull/727#discussion_r1486369386
########## libs/utils/include/celix_array_list.h: ########## @@ -468,11 +868,48 @@ CELIX_UTILS_EXPORT void celix_arrayList_sortEntries(celix_array_list_t *list, celix_array_list_compare_entries_fp compare); /** - * @warning Never use this function with array of doubles, since on some 32-bit platform (sizeof(double)==8 && sizeof(void*)==4) - * @deprecated This function is deprecated, use celix_arrayList_sortEntries instead. + * @brief Sort the array list using the array list configured compare function. + * Note that undefined the array list compare function can be NULL and in that case the array list will not be sorted. */ -CELIX_UTILS_DEPRECATED_EXPORT -void celix_arrayList_sort(celix_array_list_t *list, celix_arrayList_sort_fp sortFp); +CELIX_UTILS_EXPORT +void celix_arrayList_sort(celix_array_list_t *list); + +/** + * @brief Check if the array list are equal. + * + * Equal is defined as: + * - The array list have the same size + * - The array list have the same element type Review Comment: This is not checked in the implementation. Either documentation or implementation needs to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
