PengZheng commented on code in PR #738: URL: https://github.com/apache/celix/pull/738#discussion_r1531502865
########## bundles/event_admin/CMakeLists.txt: ########## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +celix_subproject(EVENT_ADMIN "Option to enable building the Event Admin bundles" OFF) Review Comment: > How does this work for the conan CI build? First, we have `build_all` to enable all options. Second, we have "Dependency Deduction Test" in conan_create.yml, in which we enable each option (build_xxx) in turn. > Is every option enabled by default? All `build_xxx` options default to be off. This is intentional. In my day job, we deploy dozens (if not hundreds) of Conan packages together. All default off together with automatic dependency deduction prove to be very powerful. The ultimate downstream integrator only has to choose what he/she wants, then will automatically get a minimal system fulfilling his/her needs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
