PengZheng commented on code in PR #731: URL: https://github.com/apache/celix/pull/731#discussion_r1650376329
########## conanfile.py: ########## @@ -322,6 +322,7 @@ def requirements(self): or self.options.build_rsa_discovery_common or self.options.build_rsa_remote_service_admin_dfi or self.options.build_launcher): self.requires("libcurl/[>=8.4.0 <9.0.0]") + self.requires("openssl/[>=3.2.0]") Review Comment: We don't depend on openssl directly, and thus it is better to use `self.requires("openssl/[>=3.2.0]", override=True)` to avoid introducing an extra direct dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org