xuzhenbao commented on code in PR #773:
URL: https://github.com/apache/celix/pull/773#discussion_r1853181249


##########
bundles/event_admin/event_admin_api/include/celix_event_constants.h:
##########
@@ -106,6 +106,47 @@ extern "C" {
  */
 #define CELIX_EVENT_TIMESTAMP "timestamp"
 
+/**
+ * @brief It is a property of event to indicate the event is a remote event. 
The type of the value for this event property is Boolean.
+ *
+ * If the value is true, the event will be delivered to remote
+ * event handlers and local event handlers, otherwise, the event will be only 
delivered to local event handlers.
+ */
+#define CELIX_EVENT_REMOTE_ENABLE "celix.event.remote.enable"
+
+/**
+ * @brief The QoS of the remote event. The type of the value for this event 
property is integer. It indicates the quality of service of the remote event. 
If the value is not set, the remote provider should use a proper default value.
+ *
+ * The value must be one of the following:
+ * - 0: At most once delivery
+ * - 1: At least once delivery
+ * - 2: Exactly once delivery
+ */
+#define CELIX_EVENT_REMOTE_QOS "celix.event.remote.qos"

Review Comment:
   No, this value does not affect whether sendEvent of event admin returns a 
success or not.
   However, it will affect whether the sendEvent of the remote provider returns 
success or not. For example, if the MQTT client has not yet established a 
connection with the MQTT broker, it will immediately return ENOTCONN if the QOS 
value is 0. If the QOS value is greater than 0, it will wait until the 
connection is established before sending.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to