Deedss commented on code in PR #780:
URL: https://github.com/apache/celix/pull/780#discussion_r1906858795


##########
libs/framework/src/framework.c:
##########
@@ -2686,14 +2704,26 @@ static bool 
celix_framework_isGenericEventInProgress(celix_framework_t* fw, long
 
 void celix_framework_waitForGenericEvent(celix_framework_t* fw, long eventId) {
     assert(!celix_framework_isCurrentThreadTheEventLoop(fw));
-    struct timespec logAbsTime = celixThreadCondition_getDelayedTime(5);
+    double logTimeoutInSeconds =
+        celix_framework_getConfigPropertyAsDouble(fw,
+                                                  
CELIX_ALLOWED_PROCESSING_TIME_FOR_GENERIC_EVENT_IN_SECONDS,
+                                                  
CELIX_DEFAULT_ALLOWED_PROCESSING_TIME_FOR_GENERIC_EVENT_IN_SECONDS,
+                                                  NULL);
+    struct timespec logAbsTime = 
celixThreadCondition_getDelayedTime(logTimeoutInSeconds);
     celixThreadMutex_lock(&fw->dispatcher.mutex);
+    celix_framework_event_t* event = celix_framework_getGenericEvent(fw, 
eventId);

Review Comment:
   Removed `celix_framework_isGenericEventInProgress` function and rely on 
whether the event exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to