PengZheng commented on code in PR #782:
URL: https://github.com/apache/celix/pull/782#discussion_r1922049865


##########
libs/dfi/README.md:
##########
@@ -71,9 +71,9 @@ The data types supported by the interface description include:
 
   *Type schema*:
   
-  |**Identifier**|B  |D     |F    |I      |J      |S      |V   |Z             
|b    | i      | j      | s      |P     | t                |N  | 
-  
|---------|---|------|-----|-------|-------|-------|----|--------------|-----|--------|--------|--------|------|------------------|---|
-  
|**Types**|char|double|float|int32_t|int64_t|int16_t|void|boolean(uint8)|uchar|uint32_t|uint64_t|uint16_t|void
 *| char *(C string) |int|
+  |**Identifier**|B  |D     |F    |I      |J      |S      |V   |Z             
|b    | i      | j      | s      |P     | t                |N  | p              
     | a                   |

Review Comment:
   > Maybe it is better to use different dfi descriptor for the different array 
lists (string, long, double, boolean and version).
   
   Or `a` together with type annotation using meta-info. 
   And then the RSA could do the type-checking. 
   
   Will it make the local service different from the remote ones? 
   For local service, we must do the type-checking anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to