PengZheng commented on code in PR #817:
URL: https://github.com/apache/celix/pull/817#discussion_r2748783467
##########
conanfile.py:
##########
@@ -388,7 +390,7 @@ def generate(self):
if "libcurl" in lst:
tc.cache_variables["BUILD_ERROR_INJECTOR_CURL"] = "ON"
tc.cache_variables["CELIX_ERR_BUFFER_SIZE"] =
str(self.options.celix_err_buffer_size)
-
+ tc.cache_variables["ENABLE_GCC_ANALYZER"] =
self.options.enable_gcc_analyzer
Review Comment:
```suggestion
```
This is unnecessary since it has already been done
```Python
for opt in self._celix_defaults.keys():
tc.cache_variables[opt.upper()] = self.options.get_safe(opt)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
