[ 
https://issues.apache.org/jira/browse/CMIS-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124991#comment-13124991
 ] 

Michael Dürig commented on CMIS-438:
------------------------------------

Although it might look wrong, the current code is correct: setContentStream 
must set the stream on the content node of the current node. Not on the content 
node of the context node. The patch causes setting the content stream of a 
version series to fail. 

I suggest to add a comment in the code for clarification and to resolve this 
issue as invalid. 
                
> JcrDocument.setContentStream() should call getContextNode() to get content 
> node
> -------------------------------------------------------------------------------
>
>                 Key: CMIS-438
>                 URL: https://issues.apache.org/jira/browse/CMIS-438
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-server-jcr
>    Affects Versions: OpenCMIS 0.6.0
>            Reporter: Tobias Mattsson
>            Priority: Minor
>         Attachments: JcrDocument.patch
>
>
> While all other methods in JcrFolder calls getContextNode() to get the 
> content node setContentStream() does getNode().getNode(Node.JCR_CONTENT) to 
> find it. This makes extending JcrFolder to fit a custom node structure 
> cumbersome.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to