I think it was put in there for debugging, so I believe your suggestion here would be correct. We can ask Norman, since he put that code in there (TortoiseSVN Blame command is useful for figuring out who put a line in).
Clinton From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jonathan Resnick Sent: July 12, 2007 10:45 AM To: [email protected] Subject: [clearcanvas_dev] EventsHelper I'm wondering why the EventsHelper class rethrows the exception? Having it rethrow happens to be quite useful for debugging, but conceptually I don't think it actually makes sense, and therefore it seems to me that in production code it should not rethrow the exception. The catch block currently looks like this: catch (Exception e) { Platform.Log(e, LogLevel.Error); throw e; } I think it should look like this: catch (Exception e) { Platform.Log(e, LogLevel.Error); #if DEBUG throw; #endif } Any thoughts? (Or, does anyone remember why the code is the way it is?) j
_______________________________________________ dev mailing list [email protected] http://clearcanvas.ca/mailman/listinfo/dev_clearcanvas.ca
