[
https://issues.apache.org/jira/browse/CLEREZZA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088871#comment-14088871
]
Minto van der Sluis commented on CLEREZZA-930:
----------------------------------------------
Changes made involve:
1) [Remove empty close() method on
DataAccess|https://git-wip-us.apache.org/repos/asf?p=clerezza.git;a=blobdiff;f=rdf.virtuoso.storage/src/main/java/org/apache/clerezza/rdf/virtuoso/storage/access/DataAccess.java;h=8b87ea50f3d289919a4d290be615812285ac695a;hp=1af24a4d16cbfa17fa07a1c1151be107db39a7ec;hb=2d55dbb;hpb=b0cdcfbe4a5db312ebf5d3feb0645455d1777c55]
As a result the VirtuosoProvider no longer needs to clean op all DataAccess
objects. This clean up was a problem: when should the close be done in using
the weak map (next point). The DataAccess finalizer would be the only option
left.
2)[Get rid of the internal map of graphs and the dedicated graph names
index|https://git-wip-us.apache.org/repos/asf?p=clerezza.git;a=blobdiff;f=rdf.virtuoso.storage/src/main/java/org/apache/clerezza/rdf/virtuoso/storage/access/VirtuosoWeightedProvider.java;h=34f97c0a6e1ee9937d9d0c032b56da4f5f33daf8;hp=5fc1bf75a01866c5ef2d3cd878f972f8a4f8bcbd;hb=2d55dbb;hpb=b0cdcfbe4a5db312ebf5d3feb0645455d1777c55]
The internal map prevented scalability for a number of reasons (1 keeps all
maps in memory, 2 is filled on startup). This map is replaced with a weak map
which can be seen as a map of recently used graphs. The garbage collector can
remove entries not being used when memory is low.
The special graph containing all graph names was removed as well since it was
no used for checking graph names in the first place. It makes no use to keep a
list if the list is not used (it was only used to read the graphs on startup).
@enridaga please closely review my changes. Does it still do what you want it
to do?
> Virtuoso (rdf.virtuoso.storage) based storage provider is not scalable
> ----------------------------------------------------------------------
>
> Key: CLEREZZA-930
> URL: https://issues.apache.org/jira/browse/CLEREZZA-930
> Project: Clerezza
> Issue Type: Bug
> Reporter: Minto van der Sluis
> Assignee: Minto van der Sluis
>
> Since this storage provider also uses a map to keep track of created graphs
> the same issues scalability issues apply as for: CLEREZZA-736 and CLEREZZA-805
--
This message was sent by Atlassian JIRA
(v6.2#6252)
