Thanks Hasan, I’m sorry I missed the context From: Hasan <[email protected]> Sent: Sunday, May 12, 2019 8:21 PM To: [email protected]; Reto Gmür <[email protected]> Cc: Reto Gmür <[email protected]> Subject: Re: [GitHub] [clerezza] tandhika opened a new pull request #13: Reunited
Hi Reto On Sun, May 12, 2019 at 5:49 PM Reto Gmür <[email protected]<mailto:[email protected]>> wrote: Hi Hasan I can’t see any issue looking at the list of commits. Ok, one made me curious: In https://github.com/apache/clerezza/blob/ca800183edfd494a8a3fbd5051ac58ebc6832515/sparql/src/main/java/org/apache/clerezza/sparql/GraphStore.java I find it hard to discern the difference between the two methods. This comes from the SPARQL clause FROM and FROM NAMED. And the GraphStore just models them. If this should be changed before the PR can be merged, please let me know. Otherwise, I'd suggest to merge the PR and we work on that after the merge. OK? Cheers Hasan Cheers, Reto From: GitBox <[email protected]<mailto:[email protected]>> Date: Sun, May 12, 2019 at 2:28 PM Subject: [GitHub] [clerezza] tandhika opened a new pull request #13: Reunited To: <[email protected]<mailto:[email protected]>> tandhika opened a new pull request #13: Reunited URL: https://github.com/apache/clerezza/pull/13 Refactoring Apache Clerezza to integrate clerezza-rdf-core and preparation for release ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]<mailto:[email protected]> With regards, Apache Git Services
