+1 sounds like a good suggestion. I don't think there is any MessagesMap dependency, will take a look.
regards Malcolm Edgar On Sun, Feb 28, 2010 at 8:17 AM, Finn Bock <[email protected]> wrote: > Hi, > > I noticed that the field Page.messages is defined as a MessageMap but > as far as I can see, it is only ever used as a Map (now a Map<String, > String>). If the field was defined as a Map<String, String>, it would > be easier to supply my own implementation of message map and still > re-use the field in Page. > > There is a small change that subclasses of Page might depend on the > "messages" field being defined as a MessageMap but I doubt it. > > My suggested change, as a patch: > > > Index: click/framework/src/org/apache/click/Page.java > =================================================================== > --- click/framework/src/org/apache/click/Page.java (revision 916790) > +++ click/framework/src/org/apache/click/Page.java (working copy) > @@ -174,7 +174,7 @@ > protected boolean headersEdited; > > /** The map of localized page resource messages. **/ > - protected transient MessagesMap messages; > + protected transient Map<String, String> messages; >
