[
https://issues.apache.org/jira/browse/CLK-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844739#action_12844739
]
Henry Saputra commented on CLK-642:
-----------------------------------
So when a page forwards to another page, a new context is created for that page
and push inside the ContextStack?
In this case then previous context is no longer valid I suppose and can be
replaced by new Context.
> Fix the logic to manage Context with ThreadLocal
> ------------------------------------------------
>
> Key: CLK-642
> URL: https://issues.apache.org/jira/browse/CLK-642
> Project: Click
> Issue Type: Bug
> Components: core
> Affects Versions: 2.2.0
> Reporter: Henry Saputra
> Priority: Minor
> Attachments: context_change.patch
>
>
> Currently, the Context class maintains a ThreadLocal<ContextStack> instance
> to store all contexts created for each Click request. However since Clck is
> using servlet mechanism, each request will be processed in a separate thread
> so there should be just a single Context in a thread execution lifetime.
> Within a thread scope, we could just use ThreadLocal<Context> to manage a
> single context since ThreadLocal guarantee a unique instance per thread.
> I dont think we need to manage the Context instances in ContextStack because
> there should be only one Context instance per request, which supported by
> execution in a separate thread for each request and ThreadLocal.
> I created repository for Click in codereview.appspot.com to help with code
> review and created an entry for this JIRA:
> http://codereview.appspot.com/471041/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
