[
https://issues.apache.org/jira/browse/CLK-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855600#action_12855600
]
Adrian A. commented on CLK-544:
-------------------------------
> This ticket suggests that FieldSeparator "is a" FieldSet. That doesn't seem
> right?
Yes, it is a FieldSet, but only for decorative purposes, not functional ones:
no fields can be (shall be) added to it.
The desired effect could be made with other HTML controls too, but it's just
too complicated - since FIELDSET HTML tag achieves the best result in a cross
browser manner.
However, Click already has many controls, so I'm not sure if it's justified to
add another one just for such a small "improvement" (instead of just adding
this functionality to FieldSet itself).
> FieldSeparator control.
> -----------------------
>
> Key: CLK-544
> URL: https://issues.apache.org/jira/browse/CLK-544
> Project: Click
> Issue Type: New Feature
> Components: examples
> Reporter: Adrian A.
> Assignee: Adrian A.
> Priority: Minor
> Fix For: 2.3.0
>
>
> In many forms it is required to use a "separator" between fields, to group
> them visually, but not to add them to a FieldSet (since this should be a pure
> visual effect).
> Adding the controls to a FieldSet also breaks the alignment between groups,
> since each FieldSet seems to be aligned differently (due to the use of tables
> for auto-rendering).
> A simple implementation for a FieldSeparator would look like the following
> snippet:
> <code>
> /**
> * A separator made by <b>re-using</b> the FieldSet control.<p/>
> * A special CSS style: <code>.fieldSeparator</code> is added to the HTML
> fieldset,
> * that draws only the bottom line:
> * <pre>
> * .fieldSeparator {
> * border-bottom:0;
> * border-left:0;
> * border-right:0;
> * border-top-width:4px;
> * }
> * </pre>
> *
> * @see net.sf.click.control.FieldSet
> */
> public class FieldSeparator extends FieldSet {
> public FieldSeparator() {
> }
> public FieldSeparator(String name) {
> super(name);
> addStyleClass("fieldSeparator");
> }
> public FieldSeparator(String name, String legend) {
> super(name, legend);
> addStyleClass("fieldSeparator");
> }
> // override container methods since this should be a pure visual control.
> // ....
> }
> </code>
> Thank you,
> A.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
