[
https://issues.apache.org/jira/browse/CLK-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880016#action_12880016
]
Bob Schellink commented on CLK-696:
-----------------------------------
I've noticed some of the collection generics are using Map<String, String>
where it was Map before. In essence that means moving from Map<Object, Object>
to Map<String, String> which will break backward compatibility. It also makes
programming against it more cumbersome, for example if you have a Map where the
values are Integers, one will have to convert them to Strings before
continuing. We could use toString on these values internally.
Some examples are:
RadioGroup.java:
public void addAll(Map<String, String> options) {
public static void autoPostRedirect(HttpServletRequest request,
HttpServletResponse response, String target, Map<String, String> params,
boolean compress) {
I also suggest we leave WebappResourceLoader as-is since it was copied from
Velocity and will complicate tracking changes.
Also what is the difference between Map<String, Object> and Map<String, ?>
CayenneTemplate uses this notation so I'm curious what are the advantages of
that?
> Use typesafe collection
> -----------------------
>
> Key: CLK-696
> URL: https://issues.apache.org/jira/browse/CLK-696
> Project: Click
> Issue Type: Improvement
> Components: core, extras
> Reporter: Finn Bock
> Assignee: Finn Bock
> Priority: Minor
>
> In CLK-633, the API was upgraded to use type safe collections. The remaining
> internal parts of Click should also be upgraded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
