----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16757/#review39796 -----------------------------------------------------------
https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72390> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72391> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72856> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72857> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72392> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72393> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72395> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72397> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72396> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72398> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72400> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72401> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72403> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72406> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72408> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72409> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72413> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72492> done, changed to "model_path" https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72493> done, changed to "model_path" https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72658> made two separate try-except block with using else. done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73049> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72414> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72660> couple of not necessary line moved out of try block, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72661> couple of not necessary line moved out of try block, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73048> done. https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72415> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72416> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72417> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72418> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72419> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72420> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72421> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73047> if the screen size is small, it cannot add more string and will break the code, so the except block will get it and instead print a better info, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73058> If I don't put eval here, I think this obs_info['bounding_box'][2][0] will be considered as string and return '8' but with eval it will return the whole number such as 86.5 https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73046> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73055> I think if the eval function fails, it can get the except https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73052> I just append to list, I don't think we need a function for that. What you think ? https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73045> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72422> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72663> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72664> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73044> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72423> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72499> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72424> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72916> docs have been added, no need for more functions here I guess, it is just series of processing and printing outputs https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72917> docs have been added, no need for more functions here I guess, it is just series of processing and printing outputs https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72425> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72913> moved down as global variable, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72426> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72427> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72428> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72429> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72430> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72431> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72500> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72501> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72432> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72503> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72502> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72504> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72433> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72505> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72434> removed, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72838> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72435> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72840> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72921> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72922> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73042> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72923> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73050> if the time is given is not in the required format. I added a comment on except block, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73043> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72924> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72925> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72858> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73054> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72859> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73053> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72852> removed for now, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72854> removed for now, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72853> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72855> done, https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment73051> I am not changing path, I am just changing the working dir value. https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72666> yes, the note has been removed because I define a note = "" as default in ready_screen function to remove any previous note. https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72667> yes, the note has been removed because I define a note = "" as default in ready_screen function to remove any previous note. https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72824> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72825> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72826> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72827> done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72829> good idea, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72830> edited, done https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py <https://reviews.apache.org/r/16757/#comment72833> modified, done - Maziyar Boustani On Jan. 9, 2014, 6:12 p.m., Maziyar Boustani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16757/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 6:12 p.m.) > > > Review request for Apache Open Climate. > > > Repository: climate > > > Description > ------- > > This command line tool is using latest version of OCW (Open Climate > Workbench) code to give the capability of evaluating climate model output and > observation with using available metrics along with generating plots as > result. > At this time, this tool can accept one model and one observation and to > generate contour plots with using BIAS as metric. Supporting multi model and > multi observation, more metrics and plots are in coming updates. > > > Diffs > ----- > > > https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_cml.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/16757/diff/ > > > Testing > ------- > > This tool has been tested with one model [1] and one observation [2]. > Plots were generated successfully. > > [1]: AFRICA_KNMI-RACMO2.2b_CTL_ERAINT_MM_50km_1989-2008_tasmax.nc > [2]: Dataset_id = 10 and Parameter_id = 39 > > > Thanks, > > Maziyar Boustani > >
