[ 
https://issues.apache.org/jira/browse/CLIMATE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005654#comment-14005654
 ] 

ASF GitHub Bot commented on CLIMATE-349:
----------------------------------------

Github user MBoustani commented on a diff in the pull request:

    https://github.com/apache/climate/pull/37#discussion_r12936256
  
    --- Diff: ocw/tests/test_utils.py ---
    @@ -19,10 +19,12 @@
     import urllib
     import os
     import datetime
    +from dateutil.relativedelta import relativedelta
    --- End diff --
    
    Cam, I did not noticed that this is not built-in python. It seems I had it 
installed already.
    The reason I used it to make a 2 years of datatime values, so I made first 
month and then added 24 months to it.
    Alternate options are:
    1- use 1 year for datetime values in test code and use list instead.
    2- use a code that does not require dependency for increasing month for 
more than year
    
    working on it.....


> Refactoring "reshapeMonthlyData" from rcmes/utils/misc.py 
> ----------------------------------------------------------
>
>                 Key: CLIMATE-349
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-349
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.3-incubating
>            Reporter: Maziyar Boustani
>            Assignee: Maziyar Boustani
>             Fix For: 0.4
>
>
> Refactoring function "reshapeMonthlyData" from [1] to [2] and providing 
> unittest for that.
> [1]:https://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py
> [2]:https://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/utils.py



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to