[ 
https://issues.apache.org/jira/browse/CLIMATE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049240#comment-14049240
 ] 

ASF GitHub Bot commented on CLIMATE-241:
----------------------------------------

Github user agoodm commented on the pull request:

    https://github.com/apache/climate/pull/83#issuecomment-47701572
  
     @MJJoyce 
    
    :+1: To the actual changes. I actually liked that you clarified a few of 
the parameters by adding links to relative matplotlib and basemap documentation 
too.
    
    Regarding the ```draw_subregions``` function, the "subRegion" object refers 
to the class inside the ```rcmet/src/main/python/rcmes/classes.py``` module, 
which I believe is what we used for subregion parsing in the past. The 
equivalent to this in the refactoring branch is probably 
```ocw.dataset.Bounds```.


> Make old docstrings in plotter.py sphinx compliant
> --------------------------------------------------
>
>                 Key: CLIMATE-241
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-241
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: visualization
>    Affects Versions: 0.2-incubating
>            Reporter: Alex Goodman
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>
> The old docstrings for the functions in plotter.py aren't compliant with 
> sphinx and need to be updated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to