[
https://issues.apache.org/jira/browse/CLIMATE-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061072#comment-14061072
]
Cameron Goodale commented on CLIMATE-261:
-----------------------------------------
Hay Mike,
I think we can resolve this issue as Won't Fix since the new OCW is such a
large departure from the old rcmes.toolkit approach that parsing datetimes from
strings is no longer required functionality. As the body of the issue mentions
this was opened when the ocw porting branch was being worked on.
If we need to parse strings into datetime objects in the future, then I hope
others will find the old source code and implement it within ocw, but at the
time I believe we are not going to need it.
> Consolidate Code that converts a String into a Datetime Object
> --------------------------------------------------------------
>
> Key: CLIMATE-261
> URL: https://issues.apache.org/jira/browse/CLIMATE-261
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: analysis
> Affects Versions: 0.2-incubating
> Environment: *nix
> Reporter: Cameron Goodale
> Assignee: Cameron Goodale
> Priority: Minor
> Fix For: 0.4
>
>
> Currently there are two copies of the same functionality within the rcmes
> module. These two functions are almost line for line the same code.
> rcmes.toolkit.process.decodeTimeFromString(time_string)
> vs.
> rcmes.services.decode_model_times.decodeTimeFromString(time_string)
> Since this seems like useful functionality we should pull it into the ocw
> package once the Refactoring Branch has been merged into the trunk.
> When the final implementation of this feature is written, these two functions
> will need to updated to call the canonical implementation at the least.
> The best approach would be to find and replace all places in the code that
> these functions are called, and update those places to call the new
> implementation.
> The code also needs to raise an exception if it is unable to parse the input
> string instead of just returning 0.
> Task Plan:
> =============
> 1. Develop a Canonical function within ocw to handle parsing a string into a
> Python Datetime object
> 2. Ensure the new function is unit tested and Raises an error when unable to
> Parse the string. ValueError?
> 3. Update the two functions listed in this issue so they use the new function
> within ocw
> 4. Add deprecation docstrings to the functions
--
This message was sent by Atlassian JIRA
(v6.2#6252)
