[ 
https://issues.apache.org/jira/browse/CLIMATE-492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067038#comment-14067038
 ] 

ASF GitHub Bot commented on CLIMATE-492:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/92

    CLIMATE-492 - Switch UI over to Yeomann, Grunt, and Bower

    - Resolve CLIMATE-377, CLIMATE-378
    - Switch the UI over to Yeomann, Grunt, and Bower. The system was
      restructured using the angular-generator for Yeomann [1].
    - Angular, Bootstrap, and (hopefully) all other dependencies have been
      updated to the latest versions. A number of changes had to be made to
      parts of the code base to handle these updates, especially with
      regards to the overall page layout. As near as I can tell, the UI is
      functioning as expected. Frontend tests still need to be ported!
    - Documentation needs to be updated once this becomes the official
      UI. 
    
    [1] https://github.com/yeoman/generator-angular

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate ui-restructure

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit 2e1a23361a753854c292b43c19039af8baaa5ab5
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T20:17:58Z

    Initial yeomann angular

commit 84ed645e962347cd12c53a3a657c9149926b5d09
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T20:23:30Z

    Convert DatasetDisplayCtrl over

commit cfd4a2400b5a2f7926a34b581f637f98634296dd
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T20:34:31Z

    Move over index.html

commit 2457900063ba335235b4fa50b455002414ab735f
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:08:05Z

    Add site css

commit 17bd577ef0a7da8cc5de1c16b171ec962d6c0d5c
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:25:44Z

    Update grunt-wiredep

commit dfd5d31c686f667591610ccce5949ea40081a4ce
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:25:56Z

    Add angular-ui-router

commit f878389891455c851a804262090fe8720244ddbe
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:27:14Z

    Fix datasetdisplay indentation and linting errors

commit e945578954b1c8ae1feda5171eb976171fd3561c
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:27:32Z

    Add ui.router to main app js

commit 386d1e2dea42790134365db0f12bab796cf9b0b6
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:28:52Z

    Attempt to update bootstrap grid classes and add angular-ui-router

commit 49178b75d258331aa838ebd5b3c1553ace312851
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T21:34:21Z

    Fix nav bar ul

commit 88173f0d5eb467dd31a575c00e69c6225f31143b
Author: Michael Joyce <[email protected]>
Date:   2014-07-15T22:17:47Z

    Add routing to main app script

commit 2775b92372876b609457a7aa3ecf6f3267b8506e
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T16:44:29Z

    Add DatasetSelectCtrl

commit ac34d2d8dc8a72429bce70aca074364bc28c133a
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T16:45:06Z

    Add DatasetSelectCtrl to index.html

commit 7f4f06bf18fc3fb9920099cbbdafc7b5281d5aa3
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T16:54:20Z

    Add ObservationSelectCtrl

commit c56c70ed024cc49080b6975dfea494bb5eebe745
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T16:55:28Z

    Documentation updates for ObservationSelectCtrl

commit 8ab82e95dba2b56bf291bd2ba757360606491b17
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T16:58:06Z

    Add ParameterSelectCtrl

commit 51886afc2fdd04fd86d4127bfceed614bc1e98a7
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:00:05Z

    Add RcmedSelectionCtrl

commit 3b6cc7ac48e3cf105423caa52fcf7eafad8898b7
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:01:35Z

    Add ResultCtrl

commit 041a30e895049552e2280ad085f0a7292aa7b483
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:02:36Z

    Add ResultDetailCtrl

commit d96f6c3254520e7ffdca121a40eaeee830befd30
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:03:54Z

    Add SettingsCtrl

commit 684fabe1909362f96fd281cc2b50fe6bedc1e059
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:05:22Z

    Add TimelineCtrl

commit 616428cfe92c210e22062816782d9206aab8bfea
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:06:54Z

    Add WorldMapCtrl

commit 55466e4aa0eef450166709d2fe3e87eebd8c95f6
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:09:21Z

    Add bootstrapModal directive

commit b7dd8d7e1d751175bafe5d9ef86fd7212b8a1341
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:10:31Z

    Add bootstrapModalOpen directive

commit 85d3051ebbc10ad4d064786a64d327e29708d169
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:13:12Z

    Fix boostrapmodal name problem

commit eac05b71206fbd101bfbb5bcf2d26532e385e84b
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:14:04Z

    Add leafletMap directive

commit b851b4e2d633e4ac1ba28bdce6a22b4f058fa5ae
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:14:54Z

    Add onBlur directive

commit 5c0fe0b96cd9400fe702147800454f636950c1e8
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:17:57Z

    Add predictiveFileBrowserInput directive

commit e0c0898d660dfb0305be1746eb16ded2610f9780
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:18:48Z

    Add previewMap directive

commit b39b3ddcd7860a3ff6a220c9bc93dc646a11a14c
Author: Michael Joyce <[email protected]>
Date:   2014-07-16T17:19:28Z

    Add timeline directive

----


> Move OCW-UI over to Yeomann, Bower, and Grunt
> ---------------------------------------------
>
>                 Key: CLIMATE-492
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-492
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: webapp
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>
> There are a number of issues focused on UI improvements (CLIMATE-378, 
> CLIMATE-377, CLIMATE-355) that I'm going to group under a single umbrella 
> issue.
> At the moment, we have issues with managing and updating dependencies for the 
> frontend since all libraries are managed manually. This also causes a lot of 
> bloat in the repo since we're checking in a ton of JavaScript dependencies 
> that don't need to be here.
> We're very far back from the latest Angular version and the update is only 
> going to get more and more painful the longer the we wait. This is also true 
> for Bootstrap and many (most) of the other dependencies.
> A number of the tests are currently not working (partially my fault) and 
> fixing them is even more painful since we were using an extremely old version 
> of Karma (yay, more dependency issues).
> In an effort to make maintaining the frontend easier and to hopefully prevent 
> these problems from getting worse, I've begun working on moving the project 
> over to using Yeomann, Bower, and Grunt. If you'd like to read about them 
> checkout [1] (it's a bit outdated, but still useful). At the same time, I'm 
> going through and fixing any problems that result from outdated dependencies. 
> At the moment my progress is sitting in a branch in my fork of the Climate 
> repo [2].
> [1] 
> http://www.sitepoint.com/kickstart-your-angularjs-development-with-yeoman-grunt-and-bower/
> [2] https://github.com/mjjoyce/climate/tree/ui-restructure



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to