[
https://issues.apache.org/jira/browse/CLIMATE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102311#comment-14102311
]
ASF GitHub Bot commented on CLIMATE-467:
----------------------------------------
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52650473
@huikyole, can you please squash down the CLIMATE-467 commits into fewer
commits so they're grouped properly? Can you also split the CLIMATE-508 commits
out into a separate pull request so we can test and review a single ticket
worth of changes instead of multiple? Similarly, please make the commit
messages more descriptive so someone can understand exactly why you're making
the changes. A message with just "CLIMATE-467" or "CLIMATE-467 - additional
debugging" doesn't help me understand what you're thinking =D
Thanks again for the hard work on this. I'll throw some more reviews at the
code once you've pushed these changes. If you're unsure how to squash or
cherry-pick commits feel free to ask and someone will be more than happy to
help out.
> Handling various calendar types
> -------------------------------
>
> Key: CLIMATE-467
> URL: https://issues.apache.org/jira/browse/CLIMATE-467
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: regridding/data processing
> Affects Versions: 0.3-incubating
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Priority: Minor
> Fix For: 0.5
>
>
> utils.decode_time_values needs to be updated so that we can handle daily data
> with various calendar types (ex) 'gregorian', '365 day', '360 day').
--
This message was sent by Atlassian JIRA
(v6.2#6252)
