Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/102#issuecomment-52650473
@huikyole, can you please squash down the CLIMATE-467 commits into fewer
commits so they're grouped properly? Can you also split the CLIMATE-508 commits
out into a separate pull request so we can test and review a single ticket
worth of changes instead of multiple? Similarly, please make the commit
messages more descriptive so someone can understand exactly why you're making
the changes. A message with just "CLIMATE-467" or "CLIMATE-467 - additional
debugging" doesn't help me understand what you're thinking =D
Thanks again for the hard work on this. I'll throw some more reviews at the
code once you've pushed these changes. If you're unsure how to squash or
cherry-pick commits feel free to ask and someone will be more than happy to
help out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
