+1. Some false positives, and some things to explore with DRAT. if someone has time try changing the comment block to only use /* on the JS files and let me know if that fixes it so I can file an issue upstream in RAT.
Cheers, Chris ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: [email protected] WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -----Original Message----- From: Michael Joyce <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Thursday, September 11, 2014 12:53 PM To: "[email protected]" <[email protected]> Subject: Re: [VOTE] Apache OCW 0.4 RC2 Release >Just want to bring everyone up to date. > >Chris and myself discussed the license concerns offline. This actually >seems to be a problem with RAT giving false positives. Seemingly it >doesn't >like the fact that the comment blocks begin with '/**' instead of '/*'. >All >of the above JS files should have licenses (I didn't check all of them, >but >I did address license concerns in a previous issue). The Gruntfile is auto >generated by a Yeomann generator so I didnt license that one. It is >definitely missing a header though. > >---------------- >Mike > >On Wed, Sep 10, 2014 at 8:56 PM, Mattmann, Chris A (3980) < >[email protected]> wrote: > >> +1 from me on the release! >> >> STAGING the release: >> >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% >> $HOME/git/apachestuff/stage_apache_rc climate 0.4-rc2 >> https://dist.apache.org/repos/dist/dev/climate/0.4_rc2/ >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 940k 100 940k 0 0 522k 0 0:00:01 0:00:01 --:--:-- >> 539k >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 819 100 819 0 0 2240 0 --:--:-- --:--:-- --:--:-- >> 2685 >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 61 100 61 0 0 185 0 --:--:-- --:--:-- --:--:-- >> 226 >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 807k 100 807k 0 0 379k 0 0:00:02 0:00:02 --:--:-- >> 391k >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 819 100 819 0 0 2517 0 --:--:-- --:--:-- --:--:-- >> 3078 >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 61 100 61 0 0 163 0 --:--:-- --:--:-- --:--:-- >> 193 >> >> MD5s good. >> >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% verify_md5_checksums >> md5sum: stat '*.tar.gz': No such file or directory >> md5sum: stat '*.bz2': No such file or directory >> climate-0.4-rc2.zip: OK >> climate-0.4-rc2.tgz: OK >> >> SIGS good. Note, the SIGS are only in the Git head -- Mike (you and >> I chatted offline about this) or any other RM should get their key >> into id.apache.org so it appears in the keys/group/climate.asc file. >> This is not a blocker by any means. >> >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% verify_gpg_sigs >> Verifying Signature for file climate-0.4-rc2.tgz.asc >> gpg: Signature made Mon Sep 8 13:34:53 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Can't check signature: No public key >> Verifying Signature for file climate-0.4-rc2.zip.asc >> gpg: Signature made Mon Sep 8 13:34:37 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Can't check signature: No public key >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% curl -O >> https://people.apache.org/keys/group/climate.asc >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 176k 100 176k 0 0 196k 0 --:--:-- --:--:-- --:--:-- >> 236k >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% gpg --import < climate.asc >> gpg: key 617DDBAD: "Suresh Marru (CODE SIGNING KEY) <[email protected]>" >> not changed >> gpg: key B876884A: "Chris Mattmann (CODE SIGNING KEY) >> <[email protected]>" not changed >> gpg: key 40581837: "Nick Kew <[email protected]>" not changed >> gpg: key B87F79A9: "Nick Kew <[email protected]>" not changed >> gpg: key 58EBE86D: "Cameron Goodale (FOR CODE SIGNING) >> <[email protected]>" not changed >> gpg: key 48BAEBF6: "Lewis John McGibbney (CODE SIGNING KEY) >> <[email protected]>" not changed >> gpg: Total number processed: 6 >> gpg: unchanged: 6 >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% verify_gpg_sigs >> Verifying Signature for file climate-0.4-rc2.tgz.asc >> gpg: Signature made Mon Sep 8 13:34:53 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Can't check signature: No public key >> Verifying Signature for file climate-0.4-rc2.zip.asc >> gpg: Signature made Mon Sep 8 13:34:37 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Can't check signature: No public key >> Verifying Signature for file climate.asc >> gpg: no valid OpenPGP data found. >> gpg: verify signatures failed: Unexpected error >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% curl >> >>"https://git-wip-us.apache.org/repos/asf?p=climate.git;a=blob_plain;f=KEY >>S >> ; >> hb=HEAD" -o KEYS >> % Total % Received % Xferd Average Speed Time Time Time >> Current >> Dload Upload Total Spent Left >> Speed >> 100 10328 0 10328 0 0 16889 0 --:--:-- --:--:-- --:--:-- >> 20411 >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% gpg --import < KEYS >> gpg: key 58EBE86D: "Cameron Goodale (FOR CODE SIGNING) >> <[email protected]>" not changed >> gpg: key 2C47D568: "Paul Michael Ramirez (CODE SIGNING KEY) >> <[email protected]>" not changed >> gpg: key 97E49CC0: public key "Michael Joyce (ASF Code Signing Key) >> <[email protected]>" imported >> gpg: Total number processed: 3 >> gpg: imported: 1 (RSA: 1) >> gpg: unchanged: 2 >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% verify_gpg_sigs >> Verifying Signature for file climate-0.4-rc2.tgz.asc >> gpg: Signature made Mon Sep 8 13:34:53 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Good signature from "Michael Joyce (ASF Code Signing Key) >> <[email protected]>" >> gpg: WARNING: This key is not certified with a trusted signature! >> gpg: There is no indication that the signature belongs to the >> owner. >> Primary key fingerprint: E910 C12D 9A7C 14CC ACCE D243 CB78 9D49 97E4 >>9CC0 >> Verifying Signature for file climate-0.4-rc2.zip.asc >> gpg: Signature made Mon Sep 8 13:34:37 2014 PDT using RSA key ID >>97E49CC0 >> gpg: Good signature from "Michael Joyce (ASF Code Signing Key) >> <[email protected]>" >> gpg: WARNING: This key is not certified with a trusted signature! >> gpg: There is no indication that the signature belongs to the >> owner. >> Primary key fingerprint: E910 C12D 9A7C 14CC ACCE D243 CB78 9D49 97E4 >>9CC0 >> Verifying Signature for file climate.asc >> gpg: no valid OpenPGP data found. >> gpg: verify signatures failed: Unexpected error >> [chipotle:~/tmp/climate-0.4-rc2] mattmann% >> >> I also decided why not, let's run DRAT on this :) >> >> Here's a DRAT report: >> >> $DRAT_HOME/bin/drat go $HOME/tmp/climate-0.4-rc2/climate-0.4-rc2/ >> [chipotle:data/archive/rataggregate] mattmann% cat >> rat_aggregate_stats_1410406549153.csv >> Notes,Binaries,Archives,Standards,Apache,Generated,Unknown >> 0,0,0,37,12,0,25 >> [chipotle:data/archive/rataggregate] mattmann% >> >> >> Looks like 37 standard, 12 Apache and 25 Unknown. I dug deeper >> into the Unknown: >> >> [chipotle:data/archive/rat] mattmann% cat */*.log | grep Unknown >> 1 Unknown Licenses >> 0 Unknown Licenses >> 24 Unknown Licenses >> 0 Unknown Licenses >> [chipotle:data/archive/rat] mattmann% ls -alR >> total 0 >> drwxr-xr-x 6 mattmann staff 204 Sep 10 20:35 ./ >> drwxr-xr-x 4 mattmann staff 136 Sep 10 20:35 ../ >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 css/ >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 html/ >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 javascript/ >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 x-sh/ >> >> ./css: >> total 8 >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 ./ >> drwxr-xr-x 6 mattmann staff 204 Sep 10 20:35 ../ >> -rw-r--r-- 1 mattmann staff 2264 Sep 10 20:35 >>rat_css_1410406525242.log >> >> ./html: >> total 8 >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 ./ >> drwxr-xr-x 6 mattmann staff 204 Sep 10 20:35 ../ >> -rw-r--r-- 1 mattmann staff 1555 Sep 10 20:35 >>rat_html_1410406524817.log >> >> ./javascript: >> total 96 >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 ./ >> drwxr-xr-x 6 mattmann staff 204 Sep 10 20:35 ../ >> -rw-r--r-- 1 mattmann staff 45821 Sep 10 20:35 >> rat_javascript_1410406524303.log >> >> ./x-sh: >> total 8 >> drwxr-xr-x 3 mattmann staff 102 Sep 10 20:35 ./ >> drwxr-xr-x 6 mattmann staff 204 Sep 10 20:35 ../ >> -rw-r--r-- 1 mattmann staff 1053 Sep 10 20:35 >>rat_x-sh_1410406525300.log >> [chipotle:data/archive/rat] mattmann% >> >> Looks like it's the javascript ones: >> >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/Gruntfile.j >>s >> /Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/app.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/bootstrapmo >>da >> l.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/bootstrapmo >>da >> lopen.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/datasetdisp >>la >> y.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/datasetsele >>ct >> .js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/evaluations >>et >> tings.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/isodatetomi >>dd >> leendian.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/karma.conf. >>js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/leafletmap. >>js >> /Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/main.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/observation >>se >> lect.js >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/onblur.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/parameterse >>le >> ct.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/predictivef >>il >> ebrowserinput.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/previewmap. >>js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/rcmedselect >>io >> n.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/regionselec >>tp >> arams.js >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/result.js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/resultdetai >>l. >> js >> >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/selecteddat >>as >> etinformation.js >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/settings.js >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/timeline.js >> >>/Users/mattmann/drat/deploy/data/jobs/rat/1410406524303/input/worldmap.js >> >> >> Not a blocker at all, but something to address in the future. >> >> Great job on the release, guys! >> >> Cheers, >> Chris >> >> >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Chris Mattmann, Ph.D. >> Chief Architect >> Instrument Software and Science Data Systems Section (398) >> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA >> Office: 168-519, Mailstop: 168-527 >> Email: [email protected] >> WWW: http://sunset.usc.edu/~mattmann/ >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> Adjunct Associate Professor, Computer Science Department >> University of Southern California, Los Angeles, CA 90089 USA >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> >> >> >> >> >> >> -----Original Message----- >> From: Michael Joyce <[email protected]> >> Reply-To: "[email protected]" <[email protected]> >> Date: Monday, September 8, 2014 2:42 PM >> To: "[email protected]" <[email protected]> >> Subject: [VOTE] Apache OCW 0.4 RC2 Release >> >> >Hi all, >> > >> >The second release candidate for Apache Open Climate Workbench 0.4 is >>now >> >available. >> > >> >The tag for this release is available at: >> >http://s.apache.org/anr >> > >> >Release artifacts are available for review at: >> >https://dist.apache.org/repos/dist/dev/climate/0.4_rc2/ >> > >> >Please vote on releasing these packages as Apache OCW 0.4. The vote is >> >open for the next 72 hours >> > >> >Only votes from Apache OCW PMC are binding, but folks are welcome to >>check >> >the >> >release candidate and voice their approval or disapproval. The vote >>passes >> >if at least three binding +1 votes are cast. >> > >> >[ ] +1 Release the packages as Apache OCW 0.4 >> > >> >[ ] -1 Do not release the packages because... >> > >> > >> >--- >> > >> > >> >+1 from me >> > >> > >> >-- Joyce >> >>
