[
https://issues.apache.org/jira/browse/CLIMATE-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183649#comment-14183649
]
ASF GitHub Bot commented on CLIMATE-535:
----------------------------------------
GitHub user kwhitehall opened a pull request:
https://github.com/apache/climate/pull/119
CLIMATE-535 Update mccsearch files.py to use current replacement of
toolkit.process function
removed process.py dependency and fixed Nio toNETCDF logical errors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kwhitehall/climate CLIMATE-535
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #119
----
commit 48352bc04c4fe4a1e8a03a254ecbc659424ad147
Author: Kim Whitehall <[email protected]>
Date: 2014-10-24T22:23:29Z
removed process.py dependency and fixed Nio toNETCDF logical errors
----
> Update mccsearch files.py to use current replacement of toolkit.process
> function
> --------------------------------------------------------------------------------
>
> Key: CLIMATE-535
> URL: https://issues.apache.org/jira/browse/CLIMATE-535
> Project: Apache Open Climate Workbench
> Issue Type: Task
> Components: mcc search
> Affects Versions: 0.5
> Reporter: Lewis John McGibbney
> Assignee: Kim Whitehall
> Priority: Critical
> Fix For: 0.5
>
>
> Currently files.py within the mccsearch module uses a legacy (incorrect)
> process.py (0)... which hails from the now deprecated rcmet process.py (1)
> We need to make a determination as to how this should be upgraded.
> In particular, we use the following functions
> * [process.getModelTimes(filename,
> timeVarName)|https://github.com/apache/climate/blob/master/mccsearch/code/files.py#L197]
> * [process.decode_model_timesK(ifile, timeVarName,
> file_type)|https://github.com/apache/climate/blob/master/mccsearch/code/files.py#L309]
> * [process.getModelTimes(ifile,
> timeVarName)|https://github.com/apache/climate/blob/master/mccsearch/code/files.py#L483]
> (0) https://github.com/apache/climate/blob/master/mccsearch/code/files.py#L31
> (1)
> https://github.com/apache/climate/blob/master/rcmet/src/main/python/rcmes/toolkit/process.py
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
