[ 
https://issues.apache.org/jira/browse/CLIMATE-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215367#comment-14215367
 ] 

Lewis John McGibbney commented on CLIMATE-530:
----------------------------------------------

Nice code clean up [~kwhitehall]. Over and above what you've included I would 
add 
 * the inclusion of the additional dependencies within NOTICE (0) file e.g.
{code}

    netCDF4 - http://www.unidata.ucar.edu/software/netcdf/
    sciPy - http://www.scipy.org/scipylib/index.html
    NumPy - http://www.scipy.org/scipylib/download.html
    Networkx - https://networkx.github.io/download.html
    matplotlib - http://matplotlib.org/downloads.html
    LATS4D - http://sourceforge.net/projects/opengrads/files/

{code}
 * update to mcc search README (1) to account for removal and replacement of 
GRaDS with matplotlib.

Fantastic work Kim.

(0) https://github.com/apache/climate/blob/master/NOTICE.txt
(1) 
https://github.com/apache/climate/blob/master/mccsearch/docs/mccsearch.md#what-is-needed

> Include license acknowledgment for all mccsearch dependencies
> -------------------------------------------------------------
>
>                 Key: CLIMATE-530
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-530
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: mcc search
>    Affects Versions: 0.5
>            Reporter: Lewis John McGibbney
>            Priority: Blocker
>             Fix For: 0.5
>
>
> We have a number of dependencies which are included within the mccsearch 
> codebase
>  * netCDF4 - http://www.unidata.ucar.edu/software/netcdf/
>  * sciPy - http://www.scipy.org/scipylib/index.html
>  * NumPy - http://www.scipy.org/scipylib/download.html
>  * Networkx - https://networkx.github.io/download.html
>  * matplotlib - http://matplotlib.org/downloads.html
>  * GrADS (We used OpenGrADS grads2 Version 2.0.1.oga.1) - 
> http://sourceforge.net/projects/opengrads/files/
>  * LATS4D - http://sourceforge.net/projects/opengrads/files/ 
> we need to make sure that they are acknowledged and that we can actually use 
> them all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to