[ 
https://issues.apache.org/jira/browse/CLIMATE-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333693#comment-14333693
 ] 

Kim Whitehall commented on CLIMATE-587:
---------------------------------------

In order to complete this action,the Dataset Object will have to contain a 
field for units, and  the following files and methods will have to be edited:

1.  in dataset.py, edited class Dataset to def __init__(self, lats, lons, 
times, values, variable=None, units=None, name=“")
                           edited def __str__(self): to print out the units
 2. in data_source/local.py edited load_file to read in the units for the 
variable (one liner along the lines of variable_unit = 
netcdf.variables[variable_name].units)

3. in data_source/rcmed.py edited parameter_dataset to extract units from the 
database
4. in dataset_processor.py edited ensemble to accommodate units

IMO, this amount of editing is major. So, before I push any changes, I was 
wondering, is there a reason why the Dataset class never had a "units" 
attribute ?



> Unit conversion
> ---------------
>
>                 Key: CLIMATE-587
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-587
>             Project: Apache Open Climate Workbench
>          Issue Type: Sub-task
>          Components: general
>            Reporter: Kim Whitehall
>            Assignee: Kim Whitehall
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> Add function to replicate functionality in rcmet2.1.3 that converts data 
> units from s-1 to day-1. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to