Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/155#issuecomment-76272695
Hey Kim. Two things that catch my eye immediately. First, looks like these
changes broke tests (see below). Second, it looks like you have a number of
commits all smash into a single pull request here. Did you perhaps commit
before branching and end up with all the commits in all your pull requests?
Note, this applies to all the pull requests you made.
```
+ nosetests
..............................................F........F....................F.......F..........................
======================================================================
FAIL: test_variable_propagation
(ocw.tests.test_dataset_processor.TestSpatialRegrid)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/ocw/tests/test_dataset_processor.py",
line 154, in test_variable_propagation
self.assertEquals(self.input_dataset.name, self.regridded_dataset.name)
AssertionError: 'foo' != ''
======================================================================
FAIL: test_variable_propagation
(ocw.tests.test_dataset_processor.TestTemporalRebin)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/ocw/tests/test_dataset_processor.py",
line 102, in test_variable_propagation
self.ten_year_monthly_dataset.name)
AssertionError: '' != 'foo'
======================================================================
FAIL: Test bias function between reference dataset and target dataset.
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/ocw/tests/test_metrics.py", line
57, in test_function_run
np.testing.assert_array_equal(self.bias.run(self.reference_dataset,
self.target_dataset), expected_result)
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/OCWVE/lib/python2.7/site-packages/numpy/testing/utils.py",
line 718, in assert_array_equal
verbose=verbose, header='Arrays are not equal')
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/OCWVE/lib/python2.7/site-packages/numpy/testing/utils.py",
line 644, in assert_array_compare
raise AssertionError(msg)
AssertionError:
Arrays are not equal
(mismatch 100.0%)
x: array([[[300, 300, 300, 300, 300],
[300, 300, 300, 300, 300],
[300, 300, 300, 300, 300],...
y: array([[[-300, -300, -300, -300, -300],
[-300, -300, -300, -300, -300],
[-300, -300, -300, -300, -300],...
======================================================================
FAIL: Test mean bias function between reference dataset and target dataset.
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/ocw/tests/test_metrics.py", line
209, in test_function_run
np.testing.assert_array_equal(self.mean_bias.run(self.reference_dataset,
self.target_dataset), expected_result)
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/OCWVE/lib/python2.7/site-packages/numpy/testing/utils.py",
line 718, in assert_array_equal
verbose=verbose, header='Arrays are not equal')
File
"/var/lib/jenkins/jobs/OCWPRBuild/workspace/OCWVE/lib/python2.7/site-packages/numpy/testing/utils.py",
line 644, in assert_array_compare
raise AssertionError(msg)
AssertionError:
Arrays are not equal
(mismatch 100.0%)
x: array([[ 300., 300., 300., 300., 300.],
[ 300., 300., 300., 300., 300.],
[ 300., 300., 300., 300., 300.],...
y: array([[-300, -300, -300, -300, -300],
[-300, -300, -300, -300, -300],
[-300, -300, -300, -300, -300],...
----------------------------------------------------------------------
Ran 111 tests in 37.179s
FAILED (failures=4)
Build step 'Execute shell' marked build as failure
Finished: FAILURE
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
