[
https://issues.apache.org/jira/browse/CLIMATE-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340386#comment-14340386
]
ASF GitHub Bot commented on CLIMATE-588:
----------------------------------------
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/159
CLIMATE-588 - Refactor config based evaluation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit c90440b2cd792ff74407468e951c99b091d4de14
Author: Michael Joyce <[email protected]>
Date: 2015-02-27T17:08:41Z
CLIMATE-588 - Refactor config based evaluation
----
> Refactor config based evaluation layout
> ---------------------------------------
>
> Key: CLIMATE-588
> URL: https://issues.apache.org/jira/browse/CLIMATE-588
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: general
> Affects Versions: 0.5
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Fix For: 1.0.0
>
>
> At the moment all the config evaluation handling is done in a single file.
> Functionality needs to be separated out into multiple modules for easier
> integration into other components. At the moment there are three main
> categories that the code falls into (relevant methods are listed below).
> h1. Configuration Parsing
> * is_config_valid
> * _config_is_well_formed
> * _valid_minimal_config
> * _contains_unary_metric
> * _contains_binary_metric
> * _valid_dataset_config_data
> * _fetch_built_in_metrics
> h1. Evaluation Create
> * generate_evaluation_from_config
> * _load_dataset
> * _prepare_datasets_for_evaluation
> * _load_metric
> h1. Plot Handling
> * plot_from_config
> * _draw_contour_plot
> h1. Tests
> The relevant tests should be factored to match the new code layout as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
