[
https://issues.apache.org/jira/browse/CLIMATE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647985#comment-14647985
]
ASF GitHub Bot commented on CLIMATE-643:
----------------------------------------
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/210#issuecomment-126409195
To give you an idea of what I'm talking about here @huikyole in case it's
confusing. Here's an example of how I would have broken these down into
multiple tickets and their relevant changes.
New Ticket 1:
This [new
function](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R426)
would be here.
This [variable name
update](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R409)
is related so we could include that as well.
Tests for the new function would be included in a commit in here as well.
New Ticket 2:
Missing data
[changes](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R463)
would fall in another ticket here.
Tests for this new function would be here as well.
New Ticket 3:
[This is a propagation
bug](https://github.com/apache/climate/pull/210/files#diff-e41b7ee3c7e3b2339c964f6882ecfaa5R463)
for the existing values and would be its own ticket.
New test would be included in here as well so we don't miss this bug in the
future!
New Ticket 4:
Any change in [the CLI
app](https://github.com/apache/climate/pull/210/files#diff-9e183b82ea6b20fcfefa86ca818c670eR19)
that you have in here would be in another ticket.
Would probably need to update tests if appropriate for the CLI (I'm not
familiar w/ the code so I'm unsure if that's the case)
This ticket:
The changes in
[examples/knmi_to_cru31_full_bias.py](https://github.com/apache/climate/pull/210/files#diff-a84c6055f2eee6f83c3eac5d00e324d0R28)
would be in this ticket since it's the actual update to the example file.
---
So, if these tickets build off of each other you would do something to the
effect of:
* Make feature branch off master for Ticket 1. Make changes, update tests,
and make PR
* Make feature branch off master for Ticket 2. Make changes, update tests,
and make PR. When we merge Ticket 1/2 we will need to rebase this but that
should be fine. The changes are obvious enough to make merging and issues
easy/trivial.
* Make feature branch for Ticket 3 off master. Make changes, write test,
and make PR. Will need to rebase here as well when we merge but see above.
Should be easy.
* Make feature branch for Ticket 4 off master. Etc.
* Make feature branch for this ticket. You will probably need to merge some
of the stuff in the ticket 1, 2, and 3 feature branches in here so that way you
have the changes that you need. When we merge the others into master it's
simple enough to rebase again and include those relevant commits.
---
Hopefully that helps. If you have questions let me know!
> Updating some of examples
> -------------------------
>
> Key: CLIMATE-643
> URL: https://issues.apache.org/jira/browse/CLIMATE-643
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: general
> Affects Versions: 1.0.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Fix For: 1.0.0
>
>
> Paul L. suggested some ideas to update examples. For example,
> "knmi_to_cru_full_bias.py" needs to be updated with better description. The
> model to model bias could be replaced by model to observation data bias. The
> goal is providing 5 examples all based on an actual published papers.
> Currently, OCW examples generate wrong results when there is missing data in
> observational datasets. It is important to mask those grid points with
> missing values in model datasets so that no metrics calculation is done at
> those grid points. In other words, if any of observation/model dataset has
> missing value at a grid point, we need to propagate the missing information
> to the other datasets.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
