Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/213#issuecomment-126737886
Good stuff @huikyole. Can I ask why we're copying the code from
[water_flux_unit_conversion](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L397)
nearly verbatim into this new function instead of just calling the existing
code? That's just a maintenance mistake waiting to happen and it seems like it
would be much more useful to separate out the functionality right? Then we
don't have to maintain the exact same functionality in multiple places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
