[
https://issues.apache.org/jira/browse/CLIMATE-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649420#comment-14649420
]
ASF GitHub Bot commented on CLIMATE-643:
----------------------------------------
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/213#issuecomment-126737886
Good stuff @huikyole. Can I ask why we're copying the code from
[water_flux_unit_conversion](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L397)
nearly verbatim into this new function instead of just calling the existing
code? That's just a maintenance mistake waiting to happen and it seems like it
would be much more useful to separate out the functionality right? Then we
don't have to maintain the exact same functionality in multiple places.
> Updating unit conversion function
> ----------------------------------
>
> Key: CLIMATE-643
> URL: https://issues.apache.org/jira/browse/CLIMATE-643
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: general, regridding/data processing
> Affects Versions: 1.0.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Fix For: 1.0.0
>
>
> In many cases, observational and model datasets have different units for the
> same variable. We need to update variable_unit_conversion module is needed in
> dataset_processor. This new module is based on water_flux_unit_conversion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
