GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/219
CLIMATE-654 - Clean up duplicate unit conversion code
- Cleanup duplicate unit conversion code in dataset_processor that was
introduced in CLIMATE-643. water_flux_unit_conversion is no longer
duplicated unnecessarily in variable_unit_conversion.
- Factor out temperature_unit_conversion code from
variable_unit_conversion. Formatting and isolation now matches that of
water_flux_unit_conversion. These are both called from the
variable_unit_conversion function so there's a convenient wrapper for
this functionality (as was the functionality prior to this refactor).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-654
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #219
----
commit 6fd064a31ea658cb082947557aaf90d3298f878a
Author: Michael Joyce <[email protected]>
Date: 2015-08-03T14:47:13Z
CLIMATE-654 - Clean up duplicate unit conversion code
- Cleanup duplicate unit conversion code in dataset_processor that was
introduced in CLIMATE-643. water_flux_unit_conversion is no longer
duplicated unnecessarily in variable_unit_conversion.
- Factor out temperature_unit_conversion code from
variable_unit_conversion. Formatting and isolation now matches that of
water_flux_unit_conversion. These are both called from the
variable_unit_conversion function so there's a convenient wrapper for
this functionality (as was the functionality prior to this refactor).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
