[
https://issues.apache.org/jira/browse/CLIMATE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659375#comment-14659375
]
ASF GitHub Bot commented on CLIMATE-649:
----------------------------------------
Github user MJJoyce commented on a diff in the pull request:
https://github.com/apache/climate/pull/220#discussion_r36377051
--- Diff: ocw-cli/cli_app.py ---
@@ -1232,11 +1180,11 @@ def settings_screen(header):
if option == '4':
screen.addstr(25, x/2, "Enter Spatial Gridding Option
[Model, Observation or User]:")
new_spatial_grid_option = screen.getstr()
- if new_spatial_grid_option.lower() == 'model':
- spatial_grid_option = 'Model'
- spatial_grid_setting = model_lat_res
- note = "Spatial gridding option has changed
successfully to {0}".format(spatial_grid_option)
- elif new_spatial_grid_option.lower() == 'observation':
+ #if new_spatial_grid_option.lower() == 'model':
--- End diff --
Hey @huikyole, it seems like you've just said 2 completely different
reasons for removing the code. Can you elaborate on the decision to remove this
please, I don't know that I'm following. Seemingly the two reasons you
mentioned are:
* It might be confusing to users if they loaded multiple models and we
don't provide a means to pick which option to use.
* There are models in a coordinate system that OCW doesn't handle. Also,
evidently the only models that we can possibly use with the toolkit are those
that are already regridded, so there's no point to having this option. If this
is the reason I'm not really understanding the first explanation you provided,
so perhaps I'm not understanding you properly.
> Update CLI
> ----------
>
> Key: CLIMATE-649
> URL: https://issues.apache.org/jira/browse/CLIMATE-649
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: command line interface
> Affects Versions: 1.0.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Priority: Critical
> Fix For: 0.5
>
>
> Updates include following changes.
> - It is assumed that there is only one observation data
> - time period does not have to be a multiple of 12.
> - regridding process needs to be corrected. Only two regridding options
> ('Observation' and 'User specified') are available in this new version.
> - For calculation of metrics and drawing a plot use external package, CLI
> calls example_package.py
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
