[
https://issues.apache.org/jira/browse/CLIMATE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694003#comment-14694003
]
ASF GitHub Bot commented on CLIMATE-657:
----------------------------------------
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/221#issuecomment-130410320
Truthfully @huikyole I don't see how managing this in a different branch is
too complicated. The changes aren't dependent upon each other in any way so the
branches don't even need to be merged together while you're doing your work
right?
```
# Notice the thing to fix, make new JIRA for it
git checkout master
git checkout -b CLIMATE-<new ticket id>
# make the quick changes and commit
git push github CLIMATE-<new ticket id>
# make PR
```
And you're back to working on your old issue in just a few minutes. Worst
case is there's some minor merge conflict here that takes all of 5 seconds to
fix when you go to merge the PR. Concerns are easily separated then and we're
not burying changes in unrelated tickets. There's also no reason to just remove
the test and not the relevant metric, and that's big enough of a change to be
in its own ticket I would think.
> Adding functions to calculate metrics
> -------------------------------------
>
> Key: CLIMATE-657
> URL: https://issues.apache.org/jira/browse/CLIMATE-657
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 1.0.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
>
> Currently, all the metrics defined as Class can only accept OCW dataset
> objects as input. Functions calculating metrics with input arrays will be
> added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
