[ 
https://issues.apache.org/jira/browse/CLIMATE-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736324#comment-14736324
 ] 

ASF GitHub Bot commented on CLIMATE-667:
----------------------------------------

GitHub user huikyole opened a pull request:

    https://github.com/apache/climate/pull/230

    Climate-668 - ocw.dataset_spatial_resolution needs to be fixed

    - without this fix, ocw.dataset.spatial_resolution cannot handle two 
dimensional latitudes and longitudes
    - for curvilinear latitudes and longitudes, the output of 
ocw.dataset.spatial_resolution is approximate.
    - suggested changes in CLIMATE-667 are removed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huikyole/climate CLIMATE-668

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #230
    
----
commit a0d705794f4bb2ba682a306b0e618d5feab78ef8
Author: huikyole <[email protected]>
Date:   2015-09-09T06:03:30Z

    CLIMATE-667 - OCW spatial_boundaries bug
    
    - ocw.dataset.spatial_boundaries uses np.min and np.max instead of min and 
max

commit d3b9bb5b3b294051043ce0e127dd4396ca0d7cf8
Author: huikyole <[email protected]>
Date:   2015-09-09T06:53:59Z

    CLIMATE-668 - ocw.dataset_spatial_resolution needs to be fixed
    
    - without this fix, ocw.dataset.spatial_resolution cannot handle two 
dimensional latitudes and longitudes
    - for curvilinear latitudes and longitudes, the output of 
ocw.dataset.spatial_resolution is approximate.

commit 998df0cbe543d76b5f4261aa919d07300ecd85fa
Author: huikyole <[email protected]>
Date:   2015-09-09T06:59:39Z

    CLIMATE-668 - ocw.dataset_spatial_resolution needs to be fixed
    
    - without this fix, ocw.dataset.spatial_resolution cannot handle two 
dimensional latitudes and longitudes
    - for curvilinear latitudes and longitudes, the output of 
ocw.dataset.spatial_resolution is approximate.
    - suggested changes in CLIMATE-667 are removed

----


> OCW spatial_boundaries bug
> --------------------------
>
>                 Key: CLIMATE-667
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-667
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: general
>            Reporter: Huikyo Lee
>            Assignee: Huikyo Lee
>
> Currently, dataset.spatial_boundaries does not properly find maximum and 
> minimum values of self.lats and self.lons if self.lats and self.lons are two 
> dimensional. This can be easily solved by using numpy.min and numpy.max 
> functions instead of min and max.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to