[ 
https://issues.apache.org/jira/browse/CLIMATE-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974558#comment-14974558
 ] 

ASF GitHub Bot commented on CLIMATE-556:
----------------------------------------

Github user lewismc commented on the pull request:

    https://github.com/apache/climate/pull/255#issuecomment-151211935
  
    Good job @Omkar20895 thank you for submitting your patch.
    I am having some issues, please see the attachment which indicates some 
issues with the patch. When I run it I get the following
    ```
    lmcgibbn@LMC-032857 /usr/local/climate(master) $ ./easy-ocw/install-osx.sh
    
    ---------------------------------------------------------------------------
                             Welcome to Easy OCW
    ---------------------------------------------------------------------------
    
    ./easy-ocw/install-osx.sh: line 235: syntax error: unexpected end of file
    ```
    <img width="1440" alt="screen shot 2015-10-26 at 10 08 59 am" 
src="https://cloud.githubusercontent.com/assets/1165719/10736307/78836504-7bc9-11e5-8e99-40800dcf695b.png";>
    You can see the presence of the line ending producing errors.
    If you could address the issues with an updated PR it would be fantastic? 
If you could also squash your commit history it would be fantastic... this just 
keeps the Git commit log cleaner.


> easy_install scripts should create a new virtualenv e.g. -e flag, by default
> ----------------------------------------------------------------------------
>
>                 Key: CLIMATE-556
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-556
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: easy-ocw
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 1.2
>
>
> Having sat with people recently watching them install climate, it has become 
> obvious that the default behavior for the easy_install scripts should be 
> invoking the -e flag.
> The script specifically say
> {code}
> It is recommended that you pass -e when running this script. If you don't, 
> parts
> of this installation will pollute your global Python install. If you're 
> unsure,
> pass -e just to be safe!
> {code}
> A user never sees this message though unless they know that
>  * there is a -h flag to print it
>  * it is too late and that they have already messed up their environment!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to