[
https://issues.apache.org/jira/browse/CLIMATE-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004599#comment-15004599
]
ASF GitHub Bot commented on CLIMATE-561:
----------------------------------------
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/260#issuecomment-156540829
Hey @Omkar20895,
You've got some merge related stuff in here and a few other things that we
could clean up a bit. Can you clean this up a bit. Try a rebase off master with
```rebase -i master```
after you've checked out your feature branch and squash out some of these
commits. This will also help you get rid of the historical commits that we
don't need to see in this diff.
> easy-ocw/install-osx.sh script should not assume relative locations for
> dependency utilitiy files
> -------------------------------------------------------------------------------------------------
>
> Key: CLIMATE-561
> URL: https://issues.apache.org/jira/browse/CLIMATE-561
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: easy-ocw
> Affects Versions: 0.4, 0.5
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Labels: build
> Fix For: 1.2
>
>
> Right now there are a number of flat files contained within ./easy-ocw/ which
> are utilized (very cunningly) to make the easy install process smooth.
> An improvement to the install scripts themselves would be to NOT assume these
> files are relative to where the script was invoked.
> We should be able to find these files based on a $OCW_HOME or something.
> Right now (as we are already setting virtualenv etc) I am not entirely sure
> how we do this cleanly.
> Lets talk about it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
