GitHub user MichaelArthurAnderson opened a pull request:
https://github.com/apache/climate/pull/313
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
1. Fix various Pylint complaints on dap.py and test_dap.py.
2. Add extra logic to dap.py to inspect the dimensions list rather than
just assuming time / lat / lon are the first three dimensions.
3. Update the test cases to reflect the values found in the new test file
added in CLIMATE-757.
4. Update the name of the set up function in test_dap.py to ensure set up
is called before executing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelArthurAnderson/climate CLIMATE-768
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/313.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #313
----
commit de190c6d7c562c87eadf2ce2645fa744f379f4bf
Author: MichaelArthurAnderson <[email protected]>
Date: 2016-02-26T18:23:58Z
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
commit 4e36c1db769959b870f4e49355731e19388c92d3
Author: MichaelArthurAnderson <[email protected]>
Date: 2016-02-26T18:28:46Z
CLIMATE-768 - Fix failing tests in test_dap.py. Add extra logic to dap.py
to check for named dimensions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
