[
https://issues.apache.org/jira/browse/CLIMATE-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285181#comment-15285181
]
ASF GitHub Bot commented on CLIMATE-785:
----------------------------------------
Github user lewismc commented on the pull request:
https://github.com/apache/climate/pull/334#issuecomment-219528407
+1 please merge @jarifibrahim
> RCMED.py: Optimize code
> -----------------------
>
> Key: CLIMATE-785
> URL: https://issues.apache.org/jira/browse/CLIMATE-785
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: data sources
> Reporter: Ibrahim Jarif
> Assignee: Ibrahim Jarif
> Priority: Trivial
> Labels: easyfix
>
> In ocw/data_source/rcmed.py file
> {code}
> if time_step.lower() == 'monthly':
> if time.day != 1:
> start_time_string = time.strftime('%Y%m%d')
> start_time_string = start_time_string[:6] + '01'
> time = datetime.strptime(start_time_string, '%Y%m%d')
> ##TODO: Change the 3 lines above with this line:
> ##time = datetime(time.year, time.month, 1)
> elif time_step.lower() == 'daily':
> if time.hour != 0 or time.minute != 0 or time.second != 0:
> start_time_string = time.strftime('%Y%m%d%H%M%S')
> start_time_string = start_time_string[:8] + '000000'
> time = datetime.strptime(start_time_string, '%Y%m%d%H%M%S')
> ##TODO: Change the 3 lines above with this line:
> ##time = datetime(time.year, time.month, time.day, 00, 00, 00)
> {code}
> The commented code can be used in place of the actual code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
