[ https://issues.apache.org/jira/browse/CLIMATE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393505#comment-15393505 ]
ASF GitHub Bot commented on CLIMATE-486: ---------------------------------------- Github user coveralls commented on the issue: https://github.com/apache/climate/pull/375 [](https://coveralls.io/builds/7163265) Coverage remained the same at 83.658% when pulling **d7b5f40e369049a43ef0b20904c93c7698c009e2 on jarifibrahim:CLIMATE-486** into **442a9b2d7ef0c42547f1a055a513b07face41553 on apache:master**. > Normalize DSP function parameter ordering > ------------------------------------------ > > Key: CLIMATE-486 > URL: https://issues.apache.org/jira/browse/CLIMATE-486 > Project: Apache Open Climate Workbench > Issue Type: Improvement > Components: regridding/data processing > Affects Versions: 0.3-incubating > Reporter: Michael Joyce > Assignee: Ibrahim Jarif > Labels: Newcomer > Fix For: 1.2.0 > > > Some of the DSP functions (namely subset and safe_subset) have parameter > orderings that aren't consistent with the other DSP functions. The general > ordering seems to be dsp.function(dataset(s), other, things). We should get > all of the function signatures on the same page to keep everything pretty and > user friendly. If we change the signatures of some of the functions were > going to need to make sure to update the examples as well! > Note, there might be other functions besides the two mentioned that need to > be reordered, those are just the ones I saw at first glance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)