[ https://issues.apache.org/jira/browse/CLIMATE-830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395319#comment-15395319 ]
ASF GitHub Bot commented on CLIMATE-830: ---------------------------------------- GitHub user Omkar20895 opened a pull request: https://github.com/apache/climate/pull/376 CLIMATE-830 Broken tests in dap.py - The tests fail because the dataset that I have used for testing does not contain time variable in it. - The dap.py runs on a presumption that the dataset must contain the three variables time, lat and lon necessarily. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Omkar20895/climate master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 ---- commit 615453772cfac1b3fbe7f898b22cac53945c4111 Author: Omkar20895 <omkarreddy2...@gmail.com> Date: 2016-07-27T09:39:03Z CLIMATE-830 Broken tests in dap.py ---- > Broken tests in dap.py > ---------------------- > > Key: CLIMATE-830 > URL: https://issues.apache.org/jira/browse/CLIMATE-830 > Project: Apache Open Climate Workbench > Issue Type: Bug > Affects Versions: 1.0.0 > Reporter: Omkar Reddy > Assignee: Omkar Reddy > Fix For: 1.2.0 > > > The code base in dap.py is written on a presumption that every > variable(except lat, lon and time which are 1D variables) in the dataset > loaded from OpenDap have lat, lon and time variables associated with them. It > is evident lines 53, 54 and 55 in the code. > The test cases fail when we use the dataset from this link [0]. There is only > one variable(other than lat and lon) 'scale_factor' and has only lat and lon > variables associated with it. > [0] > http://opendap-uat.jpl.nasa.gov/opendap/GeodeticsGravity/tellus/L3/mascon/RL05/JPL/CRI/netcdf/CLM4.SCALE_FACTOR.JPL.MSCNv01CRIv01.nc > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)