[
https://issues.apache.org/jira/browse/CLIMATE-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402831#comment-15402831
]
ASF GitHub Bot commented on CLIMATE-839:
----------------------------------------
GitHub user agoodm opened a pull request:
https://github.com/apache/climate/pull/380
CLIMATE-839 - Further improvements to DatasetLoader
@huikyole please review ASAP. New unit tests pass and I was able to run the
examples (note I had to make a slight change to `local.load_multiple_files()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agoodm/climate CLIMATE-839
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/380.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #380
----
commit b2f0ad4b1516b8824acb4321a463b8d7e0c7c90c
Author: Alex Goodman <ago...@users.noreply.github.com>
Date: 2016-08-01T21:11:27Z
Updates to DatasetLoader
----
> Further improvements to DatasetLoader
> -------------------------------------
>
> Key: CLIMATE-839
> URL: https://issues.apache.org/jira/browse/CLIMATE-839
> Project: Apache Open Climate Workbench
> Issue Type: Improvement
> Components: config, data sources
> Affects Versions: 1.1.0
> Reporter: Alex Goodman
> Assignee: Alex Goodman
> Fix For: 1.2.0
>
>
> I sat down with [~huikyole] and we agreed on the following improvements to
> {{DatasetLoader}}:
> 1) Stop distinguishing between reference and target datasets. This was only
> necessary for certain metrics, but in our mission to make the process of
> dataset loading more flexible we thought it would be better to keep things as
> general as possible at this step. Furthermore, we would also like to make it
> possible to process multiple observation datasets at once.
> 2) Set default loader to local. By default, if a data_source isn't specified,
> a KeyError is thrown. This will be changed to using the
> {{load_multiple_files}} loader from local. Furthermore, we do not need to
> specify 'local_multiple' and 'local' separately since the latter loader can
> easily handle the single file case, so this will be the new default loader
> rather than {{local.load_file}}.
> 3) Change 'data_source' keyword to 'loader_name'. This needs to be done at
> the config file level too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
