[ 
https://issues.apache.org/jira/browse/CLIMATE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15414407#comment-15414407
 ] 

ASF GitHub Bot commented on CLIMATE-846:
----------------------------------------

GitHub user agoodm opened a pull request:

    https://github.com/apache/climate/pull/386

    CLIMATE-846 - ESGF loader fails with new changes to run_RCMES.py

    The following bugs were fixed:
    
    - Changed loader_name from 'ESGF' to 'esgf' in the config file to make it 
compatible with `DatasetLoader`.
    - Changed the argument name of `variable` to `variable_name` in `esgf.py`, 
again for compatibility purposes with `DatasetLoader`.
    - Added `bootstrap=True` when logging on via myproxyclient. If certificates 
were not found in the users ~/.esg/certificates directory, this would result in 
an SSLError since the directory would not exist on clean systems (eg a freshly 
installed VM in which the local ESGF examples were not ran). 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agoodm/climate CLIMATE-846

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #386
    
----
commit 625eec2d2454d699e9a0dfe4e9d9a73f6c55ed57
Author: Alex Goodman <ago...@users.noreply.github.com>
Date:   2016-08-09T22:56:28Z

    Fixed issues with ESGF loader

----


> ESGF loader fails with new changes to run_RCMES.py
> --------------------------------------------------
>
>                 Key: CLIMATE-846
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-846
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: config, data sources
>    Affects Versions: 1.2.0
>            Reporter: Alex Goodman
>            Assignee: Alex Goodman
>             Fix For: 1.2.0
>
>
> ESGF example doesn't work:
> {code}
> Reading the configuration file  
> configuration_files/ESGF_example/ESGF-Example.yaml
> Loading observation datasets:
> [{'dataset_id': 
> 'obs4MIPs.CNES.AVISO.zos.mon.v20110829|esgf-data.jpl.nasa.gov', 'name': 
> 'AVISO', 'loader_name': 'ESGF', 'variable_name': 'zos'}]
> Traceback (most recent call last):
>   File "run_RCMES.py", line 101, in <module>
>     obs_datasets = load_datasets_from_config(*obs_data_info, **kwargs)
>   File "run_RCMES.py", line 40, in load_datasets_from_config
>     if password is None:
> {code}
> This should be very easy to fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to