[ 
https://issues.apache.org/jira/browse/CLIMATE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15537258#comment-15537258
 ] 

ASF GitHub Bot commented on CLIMATE-875:
----------------------------------------

Github user lewismc commented on the issue:

    https://github.com/apache/climate/pull/411
  
    Thanks Omkar.
    Can you please send a Pr to podaacpy to add these status codes to the
    function documentation?
    Thanks
    
    On Friday, September 30, 2016, Omkar <notificati...@github.com> wrote:
    
    > *@Omkar20895* commented on this pull request.
    > ------------------------------
    >
    > In ocw/data_source/podaac_datasource.py
    > <https://github.com/apache/climate/pull/411#pullrequestreview-2402455>:
    >
    > > +    '''Subset Granule service allows users to Submit subset jobs. \
    > +        Use of this service should be preceded by a Granule Search in \
    > +        order to identify and generate a list of granules to be 
subsetted.
    > +
    > +    :param input_file_path: path to a json file which contains the \
    > +        the request that you want to send to PO.DAAC
    > +    :type input_file_path: :mod:`string`
    > +
    > +    :returns: a token on successful request reception. This can be \
    > +        further used to check the status of the request.
    > +
    > +    '''
    > +    podaac = Podaac()
    > +    status = podaac.subset_status(podaac.granule_subset(input_file_path))
    > +    print("Granule subsetting initiated with request tracking token 
'%s'." % status)
    > +    while status is not "200":
    >
    > Instead of 200 it should be the string "done" here, because as much as I
    > have noticed subset_token returns the following status
    >
    >    - "submitted" : returned on successful submission
    >    - "error" : returned when there is error in the JSON POST request.
    >    - "unknown" : I am uncertain about this.
    >    - "done" : returned when subsetting is done.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/climate/pull/411#pullrequestreview-2402455>,
    > or mute the thread
    > 
<https://github.com/notifications/unsubscribe-auth/ABHJlzeAVFbzikngcPfoPhk_kRKUjV-mks5qvXnlgaJpZM4KHN4K>
    > .
    >
    
    
    -- 
    
    *Lewis*
    Dr. Lewis J. McGibbney Ph.D, B.Sc
    Director
    Phone: +1(626)498-3090
    Skype: lewis.john.mcgibbney
    Email: lewis.mcgibb...@gmail.com



> Upgrade to Podaacpy 1.3.0
> -------------------------
>
>                 Key: CLIMATE-875
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-875
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: data sources
>    Affects Versions: 1.1.0
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.2.0
>
>
> This should be a trivial upgrade of the versioning and possibly some API 
> upgrades such that OCW 1.2.0 is released with Podaac v3.2.2 Webservices 
> integration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to