[ 
https://issues.apache.org/jira/browse/CLIMATE-882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593497#comment-15593497
 ] 

ASF GitHub Bot commented on CLIMATE-882:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/climate/pull/414


> local data source is not Python 3 compatible
> --------------------------------------------
>
>                 Key: CLIMATE-882
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-882
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Alex Goodman
>            Assignee: Alex Goodman
>             Fix For: 1.2.0
>
>
> Tests are failing for our python 3 builds because of the {{local}} module. 
> Specifically, {{_get_netcdf_variable_name()}} raises an exception because 
> Python 3 implicitly treats strings as unicode instead of bytes. The culprit 
> is specifically this line:
> {code}
> dims_lower = [dim.encode().lower() for dim in dimensions]
> {code}
> Because {{encode()}} converts the strings to bytes in python 3.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to