[
https://issues.apache.org/jira/browse/CLIMATE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600000#comment-15600000
]
ASF GitHub Bot commented on CLIMATE-883:
----------------------------------------
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/climate/pull/416#discussion_r84599868
--- Diff: ocw/data_source/rcmed.py ---
@@ -74,7 +79,8 @@ def _make_mask_array(values, parameter_id,
parameters_metadata):
'''
for each in parameters_metadata:
- if each['parameter_id'].encode() == str(parameter_id):
+ if str(each['parameter_id']) == str(parameter_id):
+ print('ok')
--- End diff --
Can remove this logging @agoodm
> Ensure python 3 builds pass unit tests
> --------------------------------------
>
> Key: CLIMATE-883
> URL: https://issues.apache.org/jira/browse/CLIMATE-883
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: build process, tests
> Affects Versions: 1.1.0
> Reporter: Alex Goodman
> Assignee: Alex Goodman
> Priority: Critical
> Fix For: 1.2.0
>
>
> To make sure our code is python 3 compatible to the best of our ability, we
> need to at least make sure all of our unit tests can pass for python 3
> builds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
