[ 
https://issues.apache.org/jira/browse/CLIMATE-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971374#comment-15971374
 ] 

ASF GitHub Bot commented on CLIMATE-905:
----------------------------------------

Github user huikyole commented on a diff in the pull request:

    https://github.com/apache/climate/pull/434#discussion_r111779716
  
    --- Diff: ocw/dataset_processor.py ---
    @@ -391,8 +391,11 @@ def subset(target_dataset, subregion, 
subregion_name=None, extract=True, user_ma
         '''
     
         if not subregion.start:
    -        subregion.start = target_dataset.times[0]
    -        subregion.end = target_dataset.times[-1]
    +        time_start = target_dataset.times[0]
    --- End diff --
    
    Thanks, @agoodm . I defined time_start and time_end not to change the 
subregion object in case the object is used again for subsetting another OCW 
dataset. I will update the test.


> Box whisker plot to evaluate simulate trends
> --------------------------------------------
>
>                 Key: CLIMATE-905
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-905
>             Project: Apache Open Climate Workbench
>          Issue Type: New Feature
>          Components: visualization
>    Affects Versions: 1.1.0
>            Reporter: Huikyo Lee
>            Assignee: Huikyo Lee
>             Fix For: 1.2.0
>
>
> A new module to draw a box whisker plot and evaluate trends simulated by 
> multiple models will be added.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to