[
https://issues.apache.org/jira/browse/CLIMATE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005881#comment-16005881
]
ASF GitHub Bot commented on CLIMATE-914:
----------------------------------------
Github user huikyole commented on the issue:
https://github.com/apache/climate/pull/441
Thank you for the quick review, @agoodm. In the previous commit, I forgot
the nosetests.
- test_two_dimensional_lats_lons does not make any sense. If latitudes and
longitudes are two-dimensional, their shape must be [nY, nX]. I cannot
understand why the module had reshaped one-dimensional latitudes and longitudes.
- We can never trade off accuracy against efficiency. There is no
documentation why map_coordinates outputs -9999 without mask. I do not think
addressing this bottleneck is our top priority.
> Update dataset_processor.spatial_regrid module
> ----------------------------------------------
>
> Key: CLIMATE-914
> URL: https://issues.apache.org/jira/browse/CLIMATE-914
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: regridding/data processing
> Affects Versions: 1.2.0
> Reporter: Huikyo Lee
> Assignee: Huikyo Lee
> Priority: Blocker
> Fix For: 1.3.0
>
>
> OCW's spatial regridding has used scipy.ndimage.map_coordinates. For some
> unknown reasons, the map_coordinates function outputs -9999. as a missing
> value without a mask. We will replace map_coordinates with
> scipy.interpolate.griddata that is widely used in the climate science
> communities.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
