ASF GitHub Bot commented on CLIMATE-887:

Github user lewismc commented on the issue:

    Thank you @justinlulejian 

> test_get_netcdf_variable_names setUp to run only once for the test case
> -----------------------------------------------------------------------
>                 Key: CLIMATE-887
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-887
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 1.1.0
>            Reporter: Lewis John McGibbney
>             Fix For: 1.3.0
> Right now the particular test {code}test_get_netcdf_variable_names{code} 
> takes forever and a day due to the use of urlretrieve within the class setUp 
> function. This retrieves the same netCDF file from zipper.jpl.nasa.gov on 
> every test within the test_get_netcdf_variable_names function which is a 
> waste of time and resources. If anything, I would be +1 for having a small 
> netCDF file contained within the OCW test directory. This would speed up the 
> tests much more. 
> https://github.com/apache/climate/blob/master/ocw/tests/test_local.py#L236-L274

This message was sent by Atlassian JIRA

Reply via email to