[
https://issues.apache.org/jira/browse/CLIMATE-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315425#comment-16315425
]
ASF GitHub Bot commented on CLIMATE-374:
----------------------------------------
GitHub user MichaelArthurAnderson opened a pull request:
https://github.com/apache/climate/pull/491
CLIMATE-374 UI runEvaluation doesnt use $window or $location for resu…
CLIMATE-374 UI runEvaluation doesnt use $window or $location for results
transition
- Updated to use $location rather than window.location to transition the
input page to the results page.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelArthurAnderson/climate CLIMATE-374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/491.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #491
----
commit c7c1aeb5a13d0edfaab43c4a038f34f47baac599
Author: Michael Anderson <michaelanderson@...>
Date: 2018-01-07T18:57:48Z
CLIMATE-374 UI runEvaluation doesnt use $window or $location for results
transition
----
> UI runEvaluation doesn't use $window or $location for results transition
> ------------------------------------------------------------------------
>
> Key: CLIMATE-374
> URL: https://issues.apache.org/jira/browse/CLIMATE-374
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: webapp
> Affects Versions: 0.3-incubating
> Reporter: Michael Joyce
> Assignee: Michael Anderson
> Fix For: 1.3.0
>
>
> Need to update the uses of window.location to a more Angular approach for
> correctness and ease of testing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
